Skip to content

Conversation

@NathanMOlson
Copy link
Collaborator

  1. Set fadeDuration to 0.
  2. Don't call _render() on 'move' event
  3. On 'moveend' event, only call _render() if all tiles are loaded
  4. On 'data' event, only call _render() if all tiles are loaded
  5. If _placementDirty is true, a re-render will be required. In this case, return from _render() early, before the expensive call to painter.render()

@NathanMOlson NathanMOlson marked this pull request as draft October 17, 2024 18:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (86ed382) to head (890ea01).

❗ There is a different number of reports uploaded between BASE (86ed382) and HEAD (890ea01). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (86ed382) HEAD (890ea01)
9 8
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4852       +/-   ##
===========================================
- Coverage   87.66%   64.41%   -23.25%     
===========================================
  Files         265      265               
  Lines       37937    37953       +16     
  Branches     2407     1562      -845     
===========================================
- Hits        33257    24447     -8810     
- Misses       3608    12598     +8990     
+ Partials     1072      908      -164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NathanMOlson
Copy link
Collaborator Author

Oops, I intended to make this PR in my own fork. This is not intended to be merged.

Moved to: NathanMOlson#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants