Skip to content

reduce calls to _render() caused by jumpTo() #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+20 −3
Closed

reduce calls to _render() caused by jumpTo() #4852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/ui/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ const defaultOptions: Readonly<Partial<MapOptions>> = {
maxTileCacheZoomLevels: config.MAX_TILE_CACHE_ZOOM_LEVELS,
transformRequest: null,
transformCameraUpdate: null,
fadeDuration: 300,
fadeDuration: 0,
crossSourceCollisions: true,
clickTolerance: 3,
localIdeographFontFamily: 'sans-serif',
Expand Down Expand Up @@ -661,8 +661,17 @@ export class Map extends Camera {
this._setupContainer();
this._setupPainter();

this.on('move', () => this._update(false))
.on('moveend', () => this._update(false))
this.on('moveend', () => {
if (!this.style || !this.style.sourceCaches || !this.transform) {
return;
}
for (const id in this.style.sourceCaches) {
this.style.sourceCaches[id].update(this.transform, this.terrain);
}
if (this.areTilesLoaded()) {
this._update(false);
}
})
.on('zoom', () => this._update(true))
.on('terrain', () => {
this.painter.terrainFacilitator.dirty = true;
Expand Down Expand Up @@ -729,6 +738,9 @@ export class Map extends Camera {
}
});
this.on('data', (event: MapDataEvent) => {
if (!this.areTilesLoaded()) {
return;
}
this._update(event.dataType === 'style');
this.fire(new Event(`${event.dataType}data`, event));
});
Expand Down Expand Up @@ -3204,6 +3216,11 @@ export class Map extends Camera {

this._placementDirty = this.style && this.style._updatePlacement(this.transform, this.showCollisionBoxes, fadeDuration, this._crossSourceCollisions, transformUpdateResult.forcePlacementUpdate);

if (this._placementDirty) {
this.triggerRepaint();
return this;
}

if (transformUpdateResult.fireProjectionEvent) {
this.fire(new Event('projectiontransition', transformUpdateResult.fireProjectionEvent));
}
Expand Down