Improve pan operation with direct pointer event handling #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies mouse/touch handling by using pointer-event directly instead of the moved event with dragging state management. Changes: - Backend: Extract delta calculation explicitly for clarity - Frontend: Replace moved-based dragging with pointer-event handling - Remove drag threshold and dragging state (unnecessary complexity) - Simplify mouse cursor logic
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies mouse/touch handling for pan operations by replacing complex dragging state management with direct pointer event handling. The changes eliminate unnecessary complexity while maintaining the same functionality.
Key changes:
- Extracted delta calculation in the backend for better code clarity
- Replaced moved-based dragging with unified pointer-event handling
- Removed drag threshold and dragging state management
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/slint_maplibre_headless.cpp | Extracted delta calculation for map movement |
| examples/map_window.slint | Simplified touch handling by removing dragging state and using pointer events |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies mouse/touch handling by using pointer-event directly instead of the moved event with dragging state management.
Changes:
Description
(A brief description of the changes in this pull request)
Todos
Screenshots
(If applicable, screenshots of the changes)