Skip to content

Conversation

@CommanderStorm
Copy link
Member

This PR fixes how the part of the v8.json type system works when it comes to filters

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.70%. Comparing base (a6fe44a) to head (f641131).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1388   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files         111      111           
  Lines        4387     4387           
  Branches     1389     1389           
=======================================
  Hits         4111     4111           
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

Size Change: +32 B (+0.02%)

Total Size: 134 kB

Filename Size Change
dist/index.cjs 67.5 kB +16 B (+0.02%)
dist/index.mjs 66.4 kB +16 B (+0.02%)

compressed-size-action

@CommanderStorm CommanderStorm marked this pull request as ready for review November 29, 2025 14:16
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm concerned if this would cause any issues in maplibre-gl-js, can you check if gl js passes render tests with this updated package?

@CommanderStorm

This comment was marked as resolved.

@CommanderStorm
Copy link
Member Author

tested the gl-js tests as working. maputnik does not seem to use the typos here

@CommanderStorm CommanderStorm merged commit 2e757d5 into main Nov 29, 2025
7 checks passed
@CommanderStorm CommanderStorm deleted the filter-type-system branch November 29, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants