Skip to content

fix: filter type system in v8.json being inconsistent to how the rest of the type system works #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2025
Merged

fix: filter type system in v8.json being inconsistent to how the rest of the type system works #1388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86eb1cd
fix bad filter typing
CommanderStorm Nov 29, 2025
f641131
Merge branch 'main' into filter-type-system
CommanderStorm Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/reference/v8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@
"doc": "Size of the tile buffer on each side. A value of 0 produces no buffer. A value of 512 produces a buffer as wide as the tile itself. Larger values produce fewer rendering artifacts near tile edges and slower performance."
},
"filter": {
"type": "*",
"type": "filter",
"doc": "An expression for filtering features prior to processing them for rendering."
},
"tolerance": {
Expand Down Expand Up @@ -2777,9 +2777,16 @@
}
},
"filter": {
"type": "array",
"value": "*",
"doc": "A filter selects specific features from a layer."
"type": "boolean",
"doc": "A filter selects specific features from a layer.",
"expression": {
"interpolated": false,
"parameters": [
"zoom",
"feature"
]
},
"property-type": "data-driven"
},
"filter_operator": {
"type": "enum",
Expand Down