chore(deps): adapt to typescript 6 and strict mode#1462
chore(deps): adapt to typescript 6 and strict mode#1462CommanderStorm wants to merge 17 commits into
Conversation
CommanderStorm
changed the title
CommanderStorm
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
+ Coverage 96.04% 96.39% +0.34%
==========================================
Files 68 68
Lines 4880 4909 +29
Branches 764 787 +23
==========================================
+ Hits 4687 4732 +45
+ Misses 178 163 -15
+ Partials 15 14 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| symbolLengthStream: Uint32Array | null, | ||
| nullabilityBuffer: BitVector | null, | ||
| ): Vector | null { | ||
| symbolTableStream: Uint8Array | undefined, |
There was a problem hiding this comment.
not sure if undefined vs null is better here.
I just know that this being uneven between calle and caller makes for lots of akward conversion casts..
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
There's too many "as something" added, which I find odd like you did I think... It would be better to avoid those if possible. |
for more information, see https://pre-commit.ci
decodeString legitimately returns undefined for columns with no recognized string encoding (e.g. all zero-length streams); the previous `as Vector` cast masked this. Type it `Vector | undefined` instead of throwing, and map to null at the property-decoder call site (its existing "absent column" signal). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a lot more change, but sure. I updated the code to abort with better error messages on invariant violation |
geometryVector starts as null and `as GeometryVector | GpuVector` just stripped it. A feature table without a geometry column is malformed, so throw a descriptive error rather than constructing a FeatureTable with a null geometry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Removed them, but that forced a lot of code churn, added aborts and other things. |
|
This PR is a lot to review, any chance to slice it to smaller PRs? |
|
needs breaking apart. a bit too non-atomic. |
Split from #1462: build Column/Field as immutable discriminated-union literals (adds ColumnWithoutName) instead of `{} as Column` plus mutation.
|
While I don't fully stand behind this statement, I've checked locally and you can set |
Split from #1462. - `decodeString` now returns `undefined` for empty columns, and the dictionary/FSST decoders throw a named error when a column's companion streams are incomplete instead of constructing a half-built vector. - `propertyDecoder` keeps its existing `null` contract via `?? null`. Adds coverage for the empty/incomplete cases
I asked Claude to update us to ts6, which also apparently means strict mode.
A few of the changes that were nessary seem not quite right, but I need to investigate further.
PR mostly to give notice that I am working on this