-
-
Notifications
You must be signed in to change notification settings - Fork 255
chore: bump eslint, node and cross dependencys #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CommanderStorm
wants to merge
24
commits into
maplibre:main
Choose a base branch
from
CommanderStorm:frontend-bump1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
cbe6e93
modernise the frontends dependencys
CommanderStorm 10e4445
re-bump frontend dependencys
CommanderStorm 92bdef7
test bumping to node 22
CommanderStorm 0842984
Merge branch 'main' into frontend-bump1
CommanderStorm c21c5c0
add unzip to dependendcys for docker build
CommanderStorm 4241fc8
test moving node outside cross
CommanderStorm 5497e68
test moving node entirely outside cross
CommanderStorm 88c6586
try debuggin why node cannot finde npm
CommanderStorm f850367
Merge branch 'main' into frontend-bump1
CommanderStorm 94a34fd
test if a newer cross version does work with node
CommanderStorm 7b67b85
Revert "test if a newer cross version does work with node"
CommanderStorm 9504145
Revert "try debuggin why node cannot finde npm"
CommanderStorm 82d140b
Revert "test moving node entirely outside cross"
CommanderStorm bc49eb0
Revert "test moving node outside cross"
CommanderStorm 990acce
Revert "add unzip to dependendcys for docker build"
CommanderStorm d5be8af
test installing unzip inside of the cross isolation layer
CommanderStorm 3e91246
refactor fnm sourcing that it exists
CommanderStorm ebc517d
test calling eval directly instead of sourcing it
CommanderStorm c541632
try alternative way of using fnm
CommanderStorm b6418ef
try alternative way of installing node
CommanderStorm 6614851
Revert "try alternative way of installing node"
CommanderStorm f594bd7
retry slightly different approach to sourcing fnm
CommanderStorm bf90faa
retry with sourcing AND the most recent version of cross
CommanderStorm b501034
add more diagnostics to the cross installation
CommanderStorm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import eslint from "@eslint/js"; | ||
import reactPlugin from "eslint-plugin-react"; | ||
import reactRefresh from "eslint-plugin-react-refresh"; | ||
import globals from "globals"; | ||
import tseslint from "typescript-eslint"; | ||
|
||
export default tseslint.config( | ||
eslint.configs.recommended, | ||
{ | ||
files: ["src/**/*.{ts,tsx}"], | ||
...reactPlugin.configs.flat.recommended, | ||
languageOptions: { | ||
...reactPlugin.configs.flat.recommended.languageOptions, | ||
globals: { | ||
...globals.browser, | ||
}, | ||
}, | ||
}, | ||
{ | ||
files: ["src/**/*.{ts,tsx}"], | ||
...reactPlugin.configs.flat["jsx-runtime"], | ||
languageOptions: { | ||
...reactPlugin.configs.flat["jsx-runtime"].languageOptions, | ||
globals: { | ||
...globals.browser, | ||
}, | ||
}, | ||
}, | ||
reactRefresh.configs.vite, | ||
tseslint.configs.recommended, | ||
); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bump node to next major as required by eslint.
Bumping node requires newer libc requiring cross update.
But npm is still not quite installed in the next step (in the build script). Unsure where this is breaking apart.
Will need to look into how cross is really working.
maybe a symlink is missing, maybe more.