Skip to content

chore: bump eslint, node and cross dependencys #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

chore: bump eslint, node and cross dependencys #1789

wants to merge 24 commits into from

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Apr 12, 2025 •
edited
Loading

Our frontend dependency on eslint is a bit dated. This PR migrates them to newer versions.

Eslint was changed to their new configuration format.
Bumping eslint requires bumping node requires bumping cross (due to libc)

Splitting this into this and #1792 is likey a good idea

@Copilot Copilot AI review requested due to automatic review settings April 12, 2025 20:31
Copilot
Copilot AI reviewed Apr 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • martin/martin-ui/package.json: Language not supported

nyurik
nyurik approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! At some point we should rework CI a bit so it can auto-merge demo things without admin approval - i.e. make it so that the final CI task would pass if dependent jobs are skipped

@CommanderStorm CommanderStorm changed the title chore: modernise the frontends dependencys chore: bump eslint and vite frontend dependencys Apr 12, 2025
@CommanderStorm
Merge branch 'main' into frontend-bump1
0842984
@CommanderStorm
add unzip to dependendcys for docker build
c21c5c0
@CommanderStorm
test moving node outside cross
4241fc8
@CommanderStorm
test moving node entirely outside cross
5497e68
@CommanderStorm
try debuggin why node cannot finde npm
88c6586
@CommanderStorm
Merge branch 'main' into frontend-bump1
f850367
@CommanderStorm
test if a newer cross version does work with node
94a34fd
@CommanderStorm
Revert "test if a newer cross version does work with node"
7b67b85 
This reverts commit 94a34fd.
@CommanderStorm
Revert "try debuggin why node cannot finde npm"
9504145 
This reverts commit 88c6586.
@CommanderStorm
Revert "test moving node entirely outside cross"
82d140b 
This reverts commit 5497e68.
@CommanderStorm
Revert "test moving node outside cross"
bc49eb0 
This reverts commit 4241fc8.
@CommanderStorm
Revert "add unzip to dependendcys for docker build"
990acce 
This reverts commit c21c5c0.
@CommanderStorm
test installing unzip inside of the cross isolation layer
d5be8af
@CommanderStorm
refactor fnm sourcing that it exists
3e91246
@CommanderStorm
test calling eval directly instead of sourcing it
ebc517d
@CommanderStorm
try alternative way of using fnm
c541632
@CommanderStorm
try alternative way of installing node
b6418ef
@CommanderStorm
Revert "try alternative way of installing node"
6614851 
This reverts commit b6418ef.
@CommanderStorm
retry slightly different approach to sourcing fnm
f594bd7
@CommanderStorm
retry with sourcing AND the most recent version of cross
bf90faa
@CommanderStorm
add more diagnostics to the cross installation
b501034
@CommanderStorm CommanderStorm marked this pull request as draft April 13, 2025 21:48
CommanderStorm
CommanderStorm commented Apr 14, 2025
View reviewed changes
Cross.toml
"fnm default 22",
# verify installation
"node --version",
"npm --version",
Copy link
Collaborator Author

@CommanderStorm CommanderStorm Apr 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump node to next major as required by eslint.
Bumping node requires newer libc requiring cross update.

But npm is still not quite installed in the next step (in the build script). Unsure where this is breaking apart.

Will need to look into how cross is really working.
maybe a symlink is missing, maybe more.

@CommanderStorm CommanderStorm mentioned this pull request Apr 14, 2025
Closed
@CommanderStorm CommanderStorm changed the title chore: bump eslint and vite frontend dependencys chore: bump eslint, node and cross dependencys Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @nyurik