Skip to content

chore: bump node 17 compatible frontend dependencys #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: bump node 17 compatible frontend dependencys #1792

wants to merge 1 commit into from

Conversation

CommanderStorm
Copy link
Collaborator

this PR pulls all node 17 compatible changes from #1789 to improve said PRs scope

@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 22:15
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • martin/martin-ui/package.json: Language not supported

@CommanderStorm CommanderStorm requested a review from nyurik April 14, 2025 22:15
@CommanderStorm CommanderStorm changed the title bump node 17 compatible changes chore: bump node 17 compatible frontend dependencys Apr 14, 2025
@CommanderStorm CommanderStorm mentioned this pull request Apr 14, 2025
Draft
nyurik
nyurik approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change itself is fine, but it seems CI might have some issues with it. I'll approve to not block it later, once CI is fixed :(

@CommanderStorm
Copy link
Collaborator Author

Yea, unfortunately, these all seem to require node 18. => not splitting apparenty.

Sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @nyurik