Don't covert all property values to strings #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarelM
approved these changes
Aug 19, 2025
Collaborator
HarelM
left a comment
HarelM
left a comment
There was a problem hiding this comment.
LGTM, Was this accidentally changed as part of the typescript migration?
I'm not sure I fully understand where the issue is...
Collaborator
|
This is only a type conversion, it doesn't change the actual code, doesn't it? |
Collaborator
Author
|
Pretty sure it's just a type conversion - it looked wrong to me while debugging a related issue so I've gone ahead and fixed it. The generated code should still be the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all property values are converted to strings - even if they are otherwise allowable types. This PR removes this conversion, allowing all 3 supported types to be used and preserved.