Skip to content

Don't covert all property values to strings #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwilsnd merged 1 commit into from
Aug 19, 2025
Merged

Don't covert all property values to strings #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {type VectorTileLayer, type VectorTile, VectorTileFeature} from '@mapbox/

interface Context {
keys: string[];
values: string[];
values: (string | boolean | number)[];
keycache: Record<string, number>;
valuecache: Record<string, number>;
feature?: VectorTileFeature;
Expand Down Expand Up @@ -112,7 +112,7 @@ function writeProperties(context: Context, pbf: Pbf) {
const valueKey = typeof value + ':' + value;
let valueIndex = context.valuecache[valueKey];
if (typeof valueIndex === 'undefined') {
context.values.push(value as string);
context.values.push(value);
valueIndex = context.values.length - 1;
context.valuecache[valueKey] = valueIndex;
}
Expand Down
17 changes: 10 additions & 7 deletions test/properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ describe('property encoding', function () {
a: 'two',
b: 2,
c: { goodbye: 'planet' },
d: { hello: 'world' }
d: { hello: 'world' },
e: false
},
geometry: {
type: 'Point',
Expand All @@ -52,11 +53,13 @@ describe('property encoding', function () {

const first = layer.feature(0).properties
const second = layer.feature(1).properties
expect(first.c).toEqual('{"hello":"world"}')
expect(first.d).toEqual('[1,2,3]')
expect(first.e).toEqual(undefined)
expect(second.c).toEqual('{"goodbye":"planet"}')
expect(second.d).toEqual('{"hello":"world"}')
expect(first.b).toStrictEqual(1)
expect(first.c).toStrictEqual('{"hello":"world"}')
expect(first.d).toStrictEqual('[1,2,3]')
expect(first.e).toStrictEqual(undefined)
expect(second.c).toStrictEqual('{"goodbye":"planet"}')
expect(second.d).toStrictEqual('{"hello":"world"}')
expect(second.e).toStrictEqual(false)
})

test('number encoding https://github.com/mapbox/vt-pbf/pull/11', function () {
Expand Down Expand Up @@ -121,7 +124,7 @@ test('id encoding', function () {
const layer = vt.layers.geojsonLayer
expect(layer.feature(0).id).toEqual(123)
expect(layer.feature(1).id).toBeFalsy() // 'Non-integer values should not be saved'
expect(layer.feature(2).id).toBeFalsy()
expect(layer.feature(2).id).toBeUndefined()
})

test('accept geojson-vt options https://github.com/mapbox/vt-pbf/pull/21', function () {
Expand Down