ci(zizmor): Gate statt informativ - #8
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16c552a74e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Run zizmor | ||
| # zizmor exits non-zero when it finds issues. Run as informational | ||
| # (continue-on-error) so the job surfaces findings via SARIF/log | ||
| # without blocking unrelated CI. Fix findings to clear the warning. | ||
| continue-on-error: true | ||
| # zizmor exits non-zero bei Findings -> dieser Step GATET die CI (rot = blockt merge). |
There was a problem hiding this comment.
Making Run zizmor hard-fail here causes the job to stop before Upload SARIF runs in the common case where zizmor reports issues, because step if conditions are still subject to the default success() check unless always()/failure() is used. In this workflow, that means findings now turn CI red and skip SARIF publication, so code-scanning visibility is lost exactly when issues are detected. If gating is intended, the upload step should be made unconditional-on-failure (for example via always() plus the SARIF existence check) so findings still reach the dashboard.
Useful? React with 👍 / 👎.
1 participant
zizmor war continue-on-error (informativ). Jetzt GATE (Findings -> CI rot). Lumos ist public -> advanced-security:true + Code-Scanning-Dashboard bleiben unveraendert.