Skip to content

ci(zizmor): Gate statt informativ #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcohost33-maker merged 1 commit into from
May 25, 2026
Merged

ci(zizmor): Gate statt informativ #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ jobs:
persist-credentials: false

- name: Run zizmor
# zizmor exits non-zero when it finds issues. Run as informational
# (continue-on-error) so the job surfaces findings via SARIF/log
# without blocking unrelated CI. Fix findings to clear the warning.
continue-on-error: true
# zizmor exits non-zero bei Findings -> dieser Step GATET die CI (rot = blockt merge).
Comment on lines 34 to +35

@chatgpt-codex-connector chatgpt-codex-connector Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve SARIF upload when zizmor returns findings

Making Run zizmor hard-fail here causes the job to stop before Upload SARIF runs in the common case where zizmor reports issues, because step if conditions are still subject to the default success() check unless always()/failure() is used. In this workflow, that means findings now turn CI red and skip SARIF publication, so code-scanning visibility is lost exactly when issues are detected. If gating is intended, the upload step should be made unconditional-on-failure (for example via always() plus the SARIF existence check) so findings still reach the dashboard.

Useful? React with 👍 / 👎.

env:
# [2026-05-23] zizmor impostor-check needs authenticated GH API
# (60/h -> 1000/h). Without this: false-positive rate-limit errors.
Expand Down
Loading