Ruby: Re-enable Sorbet check#465
Conversation
|
Oh exciting! I missed that Sorbet added support for RBS type aliases! |
mickeytgl
force-pushed
the
run-sorbet-in-ci
branch
2 times, most recently
from
4893e3d to
485aaca
Compare
mickeytgl
force-pushed
the
run-sorbet-in-ci
branch
2 times, most recently
from
493feaf to
58d10cb
Compare
templates/lib/herb/ast/nodes.rb.erb
Outdated
| output += "│ └── " | ||
| <%- end -%> | ||
| output += <%= field.name %>.tree_inspect(indent).gsub(/^/, " " * (indent + 1)).lstrip.gsub(/^/, "<%= prefix %>").delete_prefix("<%= prefix %>") | ||
| output += <%= field.name %>&.tree_inspect(indent)&.gsub(/^/, " " * (indent + 1))&.lstrip&.gsub(/^/, "<%= prefix %>")&.delete_prefix("<%= prefix %>") || "" |
There was a problem hiding this comment.
This is kind of annoying, but despite checking for field_name above, Sorbet still considers it could be nil, so we need to add safe navigators on every method. It does seem to work on sig files though. It might be one of the quirks of using Sorbet with rbs
There was a problem hiding this comment.
I wonder if it might be worth to report this on Sorbet
mickeytgl
changed the title
|
Bumping this @marcoroth ⬆️ let me know if this approach makes sense or if there's something I can change |
|
Hey @mickeytgl, is this one ready to go from your side? |
|
Yes, all good. sorbet should now be green. I explicitely didn't add tying on some files (like |
There was a problem hiding this comment.
Hey @mickeytgl, thanks for working on this! I just got around to review this!
This looks good so far, but I noticed that the *.rbs files are not up-to-date. If you run bundle exec rake rbs_inline it will regenerate the *.rbs files in sig/.
But doing so leads to both failing srb tc and steep check for me locally. Would you mind taking a look? Thank you!
mickeytgl
force-pushed
the
run-sorbet-in-ci
branch
from
e956677 to
8696681
Compare
marcoroth
force-pushed
the
run-sorbet-in-ci
branch
from
3913b5d to
105b482
Compare
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
@mickeytgl I was able to rebase it and resolve the last few issues, thank you!
|
Nice! Sorry I ended up forgetting about this one |
2 participants
Now that Sorbet supports RBS aliases, this PR updates the Gemfile and modifies the files under
/libto fix any type errors raised by SorbetResolves #114