[iris] Isolate per-test ThreadContainer to drop 5s controller test teardowns#4875
Closed
claude[bot] wants to merge 1 commit intomainfrom
Closed
[iris] Isolate per-test ThreadContainer to drop 5s controller test teardowns#4875claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
…ardowns Controller tests under lib/iris/tests/cluster/controller that construct a Controller without calling .stop() leak the non-daemon log-server uvicorn thread, tripping the top-level _thread_cleanup autouse fixture's 5s wait. Install thread_container_scope as an autouse fixture so the container's on_stop hook signals server.should_exit and the thread exits immediately. Fixes #4872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controller tests under lib/iris/tests/cluster/controller construct a Controller without calling .stop(), leaking the non-daemon log-server uvicorn thread and tripping the top-level _thread_cleanup autouse fixture's 5s wait. Add an autouse thread_container_scope fixture so the container's on_stop hook signals server.should_exit on test exit and the 5s teardowns drop to under 0.2s.
Fixes #4872