Skip to content

[iris] Isolate per-test ThreadContainer to drop 5s controller test teardowns #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claude wants to merge 1 commit into from
Closed

[iris] Isolate per-test ThreadContainer to drop 5s controller test teardowns #4875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/iris/tests/cluster/controller/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

import pytest

from iris.managed_thread import thread_container_scope
from iris.cluster.bundle import BundleStore
from iris.cluster.constraints import (
Constraint,
Expand Down Expand Up @@ -112,6 +113,17 @@ def close(self) -> None:
pass


@pytest.fixture(autouse=True)
def _isolated_thread_container():
"""Install a per-test ThreadContainer so Controller-spawned threads are
stopped at test end. Without this, tests that construct a Controller but
never call ``.stop()`` leak the uvicorn log-server thread and hit the 5s
leak-detection wait in the top-level ``_thread_cleanup`` fixture.
"""
with thread_container_scope(name="controller-test"):
yield


@pytest.fixture
def state():
"""Create a fresh ControllerTransitions with temp DB and log store."""
Expand Down
Loading