Conversation
|
Claude finished @dlwh's task in 8m 14s —— View job Code review
Found 2 high-signal issues, posted as inline comments:
Investigated and dismissed (to save reviewer time): tautological-test framing of |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9824376a31
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🤖 Live MCP smoke test passed on marin-dev. I submitted |
yonromai
left a comment
There was a problem hiding this comment.
Haven't done MCP in ages, but LGTM!
| def worker_status_to_json(worker: controller_pb2.Controller.WorkerHealthStatus) -> dict[str, Any]: | ||
| """Serialize Iris worker health into stable JSON.""" | ||
| metadata = worker.metadata | ||
| return { |
There was a problem hiding this comment.
nit: https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html
will do this automatically?
|
🤖 Follow-up PR for the protobuf json_format review nit: #5071 |
Add a marin-mcp-babysitter entry point with resident Iris controller/log clients, structured job/task/log/worker/process/profile tools, Zephyr progress parsing, and diagnosis signals. Also documents MCP-assisted babysitting in the job monitoring skill after live smoke validation.
Part of #5018