Skip to content

[Iris] Improve MCP babysitting diagnostics#5071

Merged
dlwh merged 1 commit intomainfrom
codex/rjpower-json-format-worker-metadata
Apr 22, 2026
Merged

[Iris] Improve MCP babysitting diagnostics#5071
dlwh merged 1 commit intomainfrom
codex/rjpower-json-format-worker-metadata

Conversation

@dlwh
Copy link
Copy Markdown
Member

@dlwh dlwh commented Apr 22, 2026

Switch MCP worker metadata serialization to protobuf json_format and add Zephyr coordinator thread-liveness to status/diagnosis so zombie coordinators surface in structured output.

Part of #5018.

@dlwh dlwh added the agent-generated Created by automation/agent label Apr 22, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 22, 2026

Claude finished @dlwh's task in 4m 10s —— View job


Code review

No issues found. Checked for bugs and CLAUDE.md / AGENTS.md compliance.

Coverage notes (FYI, not issues):

  • _attribute_value_to_json correctly handles all three AttributeValue oneof cases (string_value, int_value, float_value) including the int64 → string round-trip from MessageToDict. Matches old WhichOneof behavior.
  • _worker_metadata_to_json's forced int-assignment pattern correctly normalizes int64 string output from MessageToDict and fills zero-defaults that would otherwise be omitted.
  • setdefault for string fields correctly fills empty strings when unset while preserving values MessageToDict already emitted.
  • Switching to MessageToDict naturally adds tpu_worker_hostnames / tpu_chips_per_host_bounds to the payload when set — previously omitted. Aligns with the stated goal of using protobuf JSON formatting, and the test covers tpu_worker_hostnames.
  • The new test exercises large 64-bit values (memory_bytes=123_456_789_012, disk_bytes=987_654_321_000) and all three AttributeValue variants, matching the PR description.

@dlwh dlwh requested a review from rjpower April 22, 2026 20:01
@dlwh dlwh force-pushed the codex/rjpower-json-format-worker-metadata branch 2 times, most recently from 51475ac to 19555b3 Compare April 22, 2026 20:10
@dlwh dlwh mentioned this pull request Apr 22, 2026
4 tasks
@dlwh dlwh force-pushed the codex/rjpower-json-format-worker-metadata branch from 19555b3 to 4c9adbd Compare April 22, 2026 22:29
@dlwh dlwh changed the title [Iris] Use protobuf JSON formatting for worker metadata [Iris] Improve MCP babysitting diagnostics Apr 22, 2026
@dlwh dlwh merged commit 0819935 into main Apr 22, 2026
40 checks passed
@dlwh dlwh deleted the codex/rjpower-json-format-worker-metadata branch April 22, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants