Check for and extract name when publish artifact definition#162
Closed
chrisghill wants to merge 1 commit into
Closed
Check for and extract name when publish artifact definition#162chrisghill wants to merge 1 commit into
chrisghill wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the extraction logic for the artifact definition to properly retrieve the name field from a nested "$md" block and updates the CODEOWNERS file.
- Update extraction logic to check for the "$md" block and its "name" field.
- Revise CODEOWNERS to update code ownership.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/definition.go | Refactored the extraction of the "name" field from a nested "$md" block. |
| .github/CODEOWNERS | Updated the owners list to reflect new code ownership. |
| return fmt.Errorf("error initializing massdriver client: %w", mdClientErr) | ||
| } | ||
|
|
||
| // TODO: All the logic from here to Publish should be moved into the commands package |
There was a problem hiding this comment.
[nitpick] Consider addressing this TODO by refactoring the logic into the commands package to improve modularity and maintainability.
Member
Author
|
Closing this, we should do this via schema validation instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to properly extract the name field to publish and artifact definition.