Skip to content

Check for and extract name when publish artifact definition #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisghill wants to merge 1 commit into from
Closed

Check for and extract name when publish artifact definition #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @coryodaniel @massdriver-cloud/platform
* @coryodaniel @chrisghill
7 changes: 6 additions & 1 deletion cmd/definition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,18 @@ func runDefinitionPublish(cmd *cobra.Command, args []string) error {
return fmt.Errorf("error initializing massdriver client: %w", mdClientErr)
}

// TODO: All the logic from here to Publish should be moved into the commands package

Copilot AI Jun 21, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider addressing this TODO by refactoring the logic into the commands package to improve modularity and maintainability.

Copilot uses AI. Check for mistakes.
def := map[string]any{}
jsonErr := json.Unmarshal(defBytes, &def)
if jsonErr != nil {
return jsonErr
}

_, nameExists := def["name"].(string)
mdBlock, mdExists := def["$md"].(map[string]any)
if !mdExists {
return fmt.Errorf("artifact definition must have a '$md' block with a 'name' field")
}
_, nameExists := mdBlock["name"].(string)
if !nameExists {
return fmt.Errorf("artifact definition must have a 'name' field")
}
Expand Down
Loading