Skip to content

QA - js#320

Open
arianebittencourt wants to merge 1 commit intomate-academy:masterfrom
arianebittencourt:develop
Open

QA - js#320
arianebittencourt wants to merge 1 commit intomate-academy:masterfrom
arianebittencourt:develop

Conversation

@arianebittencourt
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent job! Your tests successfully cover all the core requirements. You've handled the main scenarios well, such as when firstName is missing or undefined. For these reasons, your solution is approved.

As a suggestion to make your test suite even more robust, consider adding tests for edge cases in the future. For instance:

  • An empty input users array.
  • A fullName with only one word (e.g., 'Cher').

This is not a required change, just a good practice to keep in mind. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

fullName: 'Bob Smith',
},
]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests cover the main functionality well. To make the test suite more robust, it's a good practice to also test for edge cases. For instance, consider adding a test case to verify how the function behaves when it receives an empty array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants