Skip to content

QA - js #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arianebittencourt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

QA - js #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 99 additions & 3 deletions src/restoreNames.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,107 @@
'use strict';
/* eslint-disable max-len */

describe('restoreNames', () => {
// const { restoreNames } = require('./restoreNames');
const { restoreNames } = require('./restoreNames');

it('should ', () => {
it(`should be declared`, () => {
expect(restoreNames).toBeInstanceOf(Function);
});

it(`should set correct firstName to users who do not have it`, () => {
const users = [
{
lastName: 'Holy',
fullName: 'Jack Holy',
},
{
lastName: 'Adams',
fullName: 'Mike Adams',
},
];

restoreNames(users);

expect(users).toEqual([
{
firstName: 'Jack',
lastName: 'Holy',
fullName: 'Jack Holy',
},
{
firstName: 'Mike',
lastName: 'Adams',
fullName: 'Mike Adams',
},
]);
});

it(`should not change anything if user already has a firstName`, () => {
const users = [
{
firstName: 'Jack',
lastName: 'Holy',
fullName: 'Jack Holy',
},
{
firstName: 'Mike',
lastName: 'Adams',
fullName: 'Mike Adams',
},
];

restoreNames(users);

expect(users).toEqual([
{
firstName: 'Jack',
lastName: 'Holy',
fullName: 'Jack Holy',
},
{
firstName: 'Mike',
lastName: 'Adams',
fullName: 'Mike Adams',
},
]);
});

// write tests here
it(`should set correct firstName to users who's firstName is equal to undefined`, () => {
const users = [
{
firstName: undefined,
lastName: 'Holy',
fullName: 'Jack Holy',
},
{
lastName: 'Adams',
fullName: 'Mike Adams',
},
{
firstName: undefined,
lastName: 'Smith',
fullName: 'Bob Smith',
},
];

restoreNames(users);

expect(users).toEqual([
{
firstName: 'Jack',
lastName: 'Holy',
fullName: 'Jack Holy',
},
{
firstName: 'Mike',
lastName: 'Adams',
fullName: 'Mike Adams',
},
{
firstName: 'Bob',
lastName: 'Smith',
fullName: 'Bob Smith',
},
]);
});
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests cover the main functionality well. To make the test suite more robust, it's a good practice to also test for edge cases. For instance, consider adding a test case to verify how the function behaves when it receives an empty array.

});