R2024b: Update the BEV controller - #50
Merged
Merged
Conversation
Isaac-Ito-MW
self-requested a review
January 29, 2026 16:01
Isaac-Ito-MW
approved these changes
Jan 29, 2026
Isaac-Ito-MW
left a comment
Member
There was a problem hiding this comment.
This PR was issued by myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BEV motor speed controller has improved numerical robustness in some simulation cases. There were cases where simulation stalled due to a certain combination of zero crossing and saturation in the integrator block for the I term of the PI controller. The zero-crossing detection is now turned off in the integrator. Tests were performed to confirm there is no negative impact on other simulation cases.