Potential fix for code scanning alert no. 4: Incomplete string escaping or encoding - #58
Merged
Conversation
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
davidbuzinski
commented
Sep 4, 2025
| } | ||
|
|
||
| export function generateCommand(options: RunBuildOptions): string { | ||
| const pluginsPath = path.join(__dirname,"plugins").replace("'","''"); |
Collaborator
Author
There was a problem hiding this comment.
Side note: why did we need this in the first place? In case the repo name or agent workspace has a single quote in it?
Member
There was a problem hiding this comment.
Yeah, because this path is being injected into a MATLAB char array.
mcafaro
reviewed
Sep 4, 2025
Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com>
mcafaro
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to try out the Copilot Autofix feature for these changes because they're pretty small. Seems pretty cool!
Below is the generated text for the PR:
Potential fix for https://github.com/matlab-actions/run-build/security/code-scanning/4
To fix the problem, every occurrence of a single quote in the returned path string should be replaced with two single quotes, not just the first. Replace the use of
path.join(__dirname, "plugins").replace("'", "''")withpath.join(__dirname, "plugins").replace(/'/g, "''"). Only this line (line 7) needs to be changed. No new imports or external libraries are needed since the global replace using regular expressions is well-supported in JavaScript/TypeScript. No other code changes are required in this file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.