Skip to content

Potential fix for code scanning alert no. 4: Incomplete string escaping or encoding #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidbuzinski merged 7 commits into from
Sep 4, 2025
Merged

Potential fix for code scanning alert no. 4: Incomplete string escaping or encoding #58

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6400c3e
Potential fix for code scanning alert no. 4: Incomplete string escapi…
davidbuzinski Sep 4, 2025
40540df
Potential fix for code scanning alert no. 3: Incomplete string escapi…
davidbuzinski Sep 4, 2025
e0cf1e9
Use `replaceAll` instead of `replace`
davidbuzinski Sep 4, 2025
beb196a
Update buildtool.unit.test.ts
davidbuzinski Sep 4, 2025
2de60a2
bump compiler target to support replaceAll
Sep 4, 2025
2b50b8b
Merge branch 'main' of github.com:matlab-actions/run-build into codeq…
Sep 4, 2025
2106f25
Update tsconfig.json
davidbuzinski Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/buildtool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface RunBuildOptions {
}

export function generateCommand(options: RunBuildOptions): string {
const pluginsPath = path.join(__dirname,"plugins").replace("'","''");

@davidbuzinski davidbuzinski Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: why did we need this in the first place? In case the repo name or agent workspace has a single quote in it?

@mcafaro mcafaro Sep 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, because this path is being injected into a MATLAB char array.

const pluginsPath = path.join(__dirname,"plugins").replace(/'/g,"''");
Comment thread
davidbuzinski marked this conversation as resolved.
Outdated
let command: string = "addpath('"+ pluginsPath +"'); buildtool"
if (options.Tasks) {
command = command + " " + options.Tasks;
Expand Down
2 changes: 1 addition & 1 deletion src/buildtool.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as path from "path";
import * as buildtool from "./buildtool";

describe("command generation", () => {
const command = "addpath('"+ path.join(__dirname, "plugins").replace("'","''") +"'); buildtool"
const command = "addpath('"+ path.join(__dirname, "plugins").replace(/'/g,"''") +"'); buildtool"
it("buildtool invocation with unspecified tasks and build options", () => {
const options: buildtool.RunBuildOptions = {
Tasks: "",
Expand Down
Loading