Update getUrlPreview to use /_matrix/client/v1/media/preview_url#5191
Open
Update getUrlPreview to use /_matrix/client/v1/media/preview_url#5191
Conversation
Member
We do, unless we want to remove <v1.11 support from https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/version-support.ts#L27-L36 AIUI |
Contributor
Author
|
oh well, it's like two lines. |
t3chguy
reviewed
Feb 16, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
This is not a T-Task, this should be in the changelog. Pick your poison of Defect/Enhancement
Half-Shot
added
T-Defect
T-Enhancement
and removed
T-Task
Contributor
Author
|
(I entirely forgot T-Tasks don't appear in the changelog. Going with Enhancement) |
Member
|
Would be good to have some tests, surprised this doesn't make Sonar sad tbh 
|
t3chguy
approved these changes
Feb 17, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
* Update preview_url endpoint. * support <v1.11 * Add tests
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Half-Shot
added a commit
to element-hq/element-web
that referenced
this pull request
Feb 19, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been the case since v1.11 https://spec.matrix.org/v1.12/changelog/v1.11/
If we care about backwards compat further than v1.11 (so June 2024) then we can also do a switch for the older endpoint.
Checklist
public/exportedsymbols have accurate TSDoc documentation.