feat: Splitting GatewayCTMDeployer#1964
Merged
StanislavBreadless merged 46 commits intodraft-v31from Jan 26, 2026
Merged
Conversation
3 tasks
kelemeno
reviewed
Jan 19, 2026
l1-contracts/test/foundry/l1/integration/deploy-scripts/script-config/.lock
Outdated
Show resolved
Hide resolved
StanislavBreadless
requested review from
Deniallugo and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a21e7b462
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
l1-contracts/deploy-scripts/gateway/GatewayCTMDeployerHelper.sol
Outdated
Show resolved
Hide resolved
kelemeno
reviewed
Jan 23, 2026
| /// @notice Address of the ChainTypeManager implementation contract. | ||
| address chainTypeManagerImplementation; | ||
| /// @notice Address of the Verifier contract. | ||
| address verifier; |
Contributor
There was a problem hiding this comment.
can you use the verifiers struct here please
kelemeno
approved these changes
Jan 23, 2026
Contributor
|
Coverage after merging sb/split-gw-ctm-deployer into draft-v31 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
StanislavBreadless
added a commit
that referenced
this pull request
Jan 26, 2026
#1974) # What ❔ ports draft-v31 changes + the ones inside #1964 ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jcsec-security
pushed a commit
that referenced
this pull request
Jan 28, 2026
We'll have to reuse the same deployer on EVM chains, so it has to be split into multiple contracts to ensure that it fits into EVM limits. Note, that for deployments on GW, it will rely on the presence of a deterministic CREATE2 factory. I have NOT yet deeply reviewed it, so comments may contains occasional errors, this PR is to demonstrate what the feature will look like overall. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jcsec-security
pushed a commit
that referenced
this pull request
Jan 28, 2026
We'll have to reuse the same deployer on EVM chains, so it has to be split into multiple contracts to ensure that it fits into EVM limits. Note, that for deployments on GW, it will rely on the presence of a deterministic CREATE2 factory. I have NOT yet deeply reviewed it, so comments may contains occasional errors, this PR is to demonstrate what the feature will look like overall. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jcsec-security
pushed a commit
that referenced
this pull request
Jan 28, 2026
We'll have to reuse the same deployer on EVM chains, so it has to be split into multiple contracts to ensure that it fits into EVM limits. Note, that for deployments on GW, it will rely on the presence of a deterministic CREATE2 factory. I have NOT yet deeply reviewed it, so comments may contains occasional errors, this PR is to demonstrate what the feature will look like overall. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
We'll have to reuse the same deployer on EVM chains, so it has to be split into multiple contracts to ensure that it fits into EVM limits.
Note, that for deployments on GW, it will rely on the presence of a deterministic CREATE2 factory.
I have NOT yet deeply reviewed it, so comments may contains occasional errors, this PR is to demonstrate what the feature will look like overall.
Why ❔
Checklist