Skip to content

fix: update upgrade with new oidc deploy#459

Merged
cpb8010 merged 2 commits intomainfrom
fix-upgrade
Aug 1, 2025
Merged

fix: update upgrade with new oidc deploy#459
cpb8010 merged 2 commits intomainfrom
fix-upgrade

Conversation

@cpb8010
Copy link
Contributor

@cpb8010 cpb8010 commented Aug 1, 2025

Description

Missing update from change

Additional context

pnpm run upgrade --proxyfile ../auth-server/stores/era-sepolia.json --keyregistryowner 0x0lol --network zkSyncSepoliaTestnet

> zksync-sso-contracts@ upgrade zksync-sso/packages/contracts
> hardhat upgrade "--proxyfile" "../auth-server/stores/era-sepolia.json" "--keyregistryowner" "0x0lol" "--network" "zkSyncSepoliaTestnet"

Deploying new implementation of undefined contract...
Deploying to: zkSyncSepoliaTestnet
Using custom key registry owner
Deploying WebAuthValidator contract...
Contract WebAuthValidator already exists!
WebAuthValidator contract deployed at: 0x98083a10aa0dC1539267A2e00a7a367D15a21aA3 

Deploying SessionKeyValidator contract...
Contract SessionKeyValidator already exists!
SessionKeyValidator contract deployed at: 0x5EFc9e90db7e6C38D0f0f464721a17f753dd0a5D 

Deploying SsoAccount contract...
Contract SsoAccount already exists!
SsoAccount contract deployed at: 0xC5362ef95D6fa621F559Fce962b272970Fdb5C47 

Deploying SsoBeacon contract...
Contract SsoBeacon already exists!
SsoBeacon contract deployed at: 0x2f0ad6718dc6e44a7dCc078e0250764938D77E57 

Deploying AAFactory contract...
Factory already exists at 0xb97b15BF3C18877D3182482F6a422f8500DF3C7e
AAFactory contract deployed at: 0xb97b15BF3C18877D3182482F6a422f8500DF3C7e 

Deploying GuardianRecoveryValidator contract...
Contract GuardianRecoveryValidator already exists!
GuardianRecoveryValidator contract deployed at: 0x7c9093afa51d5f4DFEc349fEa1e897CffAeCA57f 

Deploying OidcKeyRegistry contract...
Contract OidcKeyRegistry already exists!
OidcKeyRegistry contract deployed at: 0x0EEeA31EA37959316dc6b50307BaF09528d3fcc4 

Key registry already initialized

Deploying Groth16Verifier contract...
Contract Groth16Verifier already exists!
Groth16Verifier contract deployed at: 0x271e7A4E14d5950ea12B1Fc8a6B79B71225A40a1 

Deploying OidcRecoveryValidator contract...
Contract OidcRecoveryValidator already exists!
OidcRecoveryValidator contract deployed at: 0x116A07f88d03bD3982eBD5f2667EB08965aAe98c 

Deploying ExampleAuthServerPaymaster contract...
Contract ExampleAuthServerPaymaster already exists!
ExampleAuthServerPaymaster contract deployed at: 0x392565cccbAa4a9d811EaD1527C9747248E79160 

--fund flag not provided, skipping funding paymaster

New beacon implementation deployed at 0x2f0ad6718dc6e44a7dCc078e0250764938D77E57
No proxy address found for beacon in ../auth-server/stores/era-sepolia.json
New session implementation deployed at 0x5EFc9e90db7e6C38D0f0f464721a17f753dd0a5D
Upgrading session proxy at 0x64Fa4b6fCF655024e6d540E0dFcA4142107D4fBC
Proxy upgraded successfully
New passkey implementation deployed at 0x98083a10aa0dC1539267A2e00a7a367D15a21aA3
Upgrading passkey proxy at 0x006ecc2D79242F1986b7cb5F636d6E3f499f1026
Proxy upgraded successfully
New accountFactory implementation deployed at 0xb97b15BF3C18877D3182482F6a422f8500DF3C7e
Upgrading accountFactory proxy at 0xd122999B15081d90b175C81B8a4a9bE3327C0c2a
Proxy upgraded successfully
New accountPaymaster implementation deployed at 0x392565cccbAa4a9d811EaD1527C9747248E79160
ExampleAuthServerPaymaster not a proxy
New recovery implementation deployed at 0x7c9093afa51d5f4DFEc349fEa1e897CffAeCA57f
Upgrading recovery proxy at 0x6AA83E35439D71F28273Df396BC7768dbaA9849D
Proxy upgraded successfully
New recoveryOidc implementation deployed at 0x116A07f88d03bD3982eBD5f2667EB08965aAe98c
No proxy address found for recoveryOidc in ../auth-server/stores/era-sepolia.json
New oidcKeyRegistry implementation deployed at 0x0EEeA31EA37959316dc6b50307BaF09528d3fcc4
No proxy address found for oidcKeyRegistry in ../auth-server/stores/era-sepolia.json

Used to upgrade to latest
@cpb8010 cpb8010 self-assigned this Aug 1, 2025
@cpb8010 cpb8010 added bug Something isn't working good first issue Good for newcomers project: auth server labels Aug 1, 2025
@cpb8010 cpb8010 requested a review from Copilot August 1, 2025 00:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the upgrade script to properly handle the new OIDC deployment functionality by adding the missing keyregistryowner parameter and fixing parameter order issues.

  • Adds missing keyregistryowner parameter to the upgrade task
  • Fixes parameter order in function calls to match updated signatures
  • Improves error handling for missing proxy addresses

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/upgrade.ts Adds keyregistryowner parameter, fixes parameter order in deployCmd call, and improves proxy address validation
scripts/deploy.ts Corrects parameter order in deployCmd function signature to match usage

was included in sdk, but not automatically published
@cpb8010 cpb8010 merged commit c165f0b into main Aug 1, 2025
7 checks passed
@cpb8010 cpb8010 deleted the fix-upgrade branch August 1, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers project: auth server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants