Conversation
Used to upgrade to latest
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the upgrade script to properly handle the new OIDC deployment functionality by adding the missing keyregistryowner parameter and fixing parameter order issues.
- Adds missing
keyregistryownerparameter to the upgrade task - Fixes parameter order in function calls to match updated signatures
- Improves error handling for missing proxy addresses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/upgrade.ts | Adds keyregistryowner parameter, fixes parameter order in deployCmd call, and improves proxy address validation |
| scripts/deploy.ts | Corrects parameter order in deployCmd function signature to match usage |
was included in sdk, but not automatically published
JackHamer09
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Missing update from change
Additional context