feat(chore): adding optional credentials parameter so passkey signing can skip passkey dialog#177
Closed
githubdoramon wants to merge 6 commits intomatter-labs:mainfrom
Closed
Conversation
… can skip passkey dialog
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an optional credentials parameter to the passkey authentication flow, allowing developers to skip the passkey selection dialog by providing a pre-stored credential object from passkey registration.
- Adds optional
credentialparameter to authentication interfaces and functions - Modifies authentication options to use the provided credential when available
- Updates the client configuration to accept the optional credential parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/sdk/src/client/passkey/client.ts | Adds credential parameter to client config and passes it to authentication request |
| packages/sdk/src/client/passkey/actions/passkey.ts | Updates authentication function to accept and use optional credential parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thank you copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JackHamer09
previously approved these changes
Sep 5, 2025
cpb8010
previously approved these changes
Sep 9, 2025
Contributor
cpb8010
left a comment
cpb8010
left a comment
There was a problem hiding this comment.
Yes, great improvement if you have the passkey managed outside of the SDK!
githubdoramon
dismissed stale reviews from cpb8010 and JackHamer09
via
f9f6e68
Author
|
Closing as another PR was created for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an additional parameter to passkey authentican flow, allowing developer to pass a credentials object (stored from the passkey registration), in order for passkey signing to not require the passkey selection dialog to be shown to user.
Additional context
Highly improves signing UX with passkeys