Skip to content

feat: adding support for custom provider on connector arguments#178

Merged
JackHamer09 merged 2 commits intomatter-labs:mainfrom
sophon-org:feat/custom-provider
Sep 9, 2025
Merged

feat: adding support for custom provider on connector arguments#178
JackHamer09 merged 2 commits intomatter-labs:mainfrom
sophon-org:feat/custom-provider

Conversation

@falleco
Copy link
Contributor

@falleco falleco commented Sep 1, 2025

Description

Adding more customisation options to the connector creator to allow:

  • custom Provider handling
  • custom connector metadata (like name, icon, id) and not use static 'zksync-sso'

@cpb8010 cpb8010 requested a review from Copilot September 2, 2025 04:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds customization options to the ZKsync SSO connector, allowing developers to override default connector metadata and provide custom provider implementations instead of being limited to the hardcoded "zksync-sso" configuration.

  • Introduces ConnectorMetadata type for customizable connector properties (icon, id, name, type)
  • Adds optional provider and connectorMetadata parameters to ZksyncSsoConnectorOptions
  • Updates connector creation to use custom metadata with fallback to default values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JackHamer09 JackHamer09 enabled auto-merge (squash) September 5, 2025 13:02
@JackHamer09 JackHamer09 merged commit 9640832 into matter-labs:main Sep 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants