Skip to content

feat: adding support for custom provider on connector arguments #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackHamer09 merged 2 commits into from
Sep 9, 2025
Merged

feat: adding support for custom provider on connector arguments #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5552d4c
feat: adding support for custom provider on connector arguments + met…
falleco Sep 1, 2025
d98b658
Merge branch 'main' into feat/custom-provider
githubdoramon Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions packages/sdk/src/connector/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,27 @@ import { type AppMetadata, type ProviderInterface, type SessionPreferences, Wall
import type { CustomPaymasterHandler } from "../paymaster/index.js";
export { callPolicy } from "../client-auth-server/index.js";

export type ConnectorMetadata = {
icon: string;
id: string;
name: string;
type: string;
};

export type ZksyncSsoConnectorOptions = {
metadata?: Partial<AppMetadata>;
session?: SessionPreferences | (() => SessionPreferences | Promise<SessionPreferences>);
authServerUrl?: string;
paymasterHandler?: CustomPaymasterHandler;
communicator?: Communicator;
provider?: ProviderInterface;
connectorMetadata?: ConnectorMetadata;
};

export const zksyncSsoConnector = (parameters: ZksyncSsoConnectorOptions) => {
type Provider = ProviderInterface;

let walletProvider: WalletProvider | undefined;
let walletProvider: Provider | undefined;

let accountsChanged: Connector["onAccountsChanged"] | undefined;
let chainChanged: Connector["onChainChanged"] | undefined;
Expand All @@ -59,11 +68,11 @@ export const zksyncSsoConnector = (parameters: ZksyncSsoConnectorOptions) => {
};

return createConnector<Provider>((config) => ({
icon: "https://zksync.io/favicon.ico",
id: "zksync-sso",
name: "ZKsync",
icon: parameters.connectorMetadata?.icon ?? "https://zksync.io/favicon.ico",
id: parameters.connectorMetadata?.id ?? "zksync-sso",
name: parameters.connectorMetadata?.name ?? "ZKsync",
type: parameters.connectorMetadata?.type ?? "zksync-sso",
// supportsSimulation: true,
type: "zksync-sso",
async connect({ chainId } = {}) {
try {
const provider = await this.getProvider();
Expand Down Expand Up @@ -135,7 +144,7 @@ export const zksyncSsoConnector = (parameters: ZksyncSsoConnectorOptions) => {
},
async getProvider() {
if (!walletProvider) {
walletProvider = new WalletProvider({
walletProvider = parameters.provider ?? new WalletProvider({
metadata: {
name: parameters.metadata?.name,
icon: parameters.metadata?.icon,
Expand Down
Loading