feat(swift sdk): swift sdk implementation#92
Merged
jackpooleyml merged 2 commits intomainfrom Mar 14, 2025
Merged
Conversation
jackpooleyml
force-pushed
the
jack/swift-sdk
branch
7 times, most recently
from
f1b0cec to
b87b9d7
Compare
jackpooleyml
force-pushed
the
jack/swift-sdk
branch
from
b87b9d7 to
4165471
Compare
jackpooleyml
force-pushed
the
jack/swift-sdk
branch
from
4165471 to
a61bf7f
Compare
MexicanAce
reviewed
Mar 13, 2025
packages/sdk-platforms/rust/zksync-sso/scripts/check_account_public_key.sh
Show resolved
Hide resolved
packages/sdk-platforms/rust/zksync-sso/crates/ffi/src/account/deployment.rs
Show resolved
Hide resolved
packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/client/passkey/actions/passkey.rs
Show resolved
Hide resolved
packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/utils/alloy/conveniences.rs
Outdated
Show resolved
Hide resolved
packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/utils/encoding.rs
Outdated
Show resolved
Hide resolved
...-platforms/rust/zksync-sso/crates/sdk/src/utils/manual_build_transaction/register_passkey.rs
Show resolved
Hide resolved
...-platforms/rust/zksync-sso/crates/sdk/src/utils/manual_build_transaction/register_passkey.rs
Show resolved
Hide resolved
jackpooleyml
force-pushed
the
jack/swift-sdk
branch
4 times, most recently
from
a0143c8 to
aafacce
Compare
jackpooleyml
force-pushed
the
jack/swift-sdk
branch
from
aafacce to
0e63f6d
Compare
MexicanAce
approved these changes
Mar 14, 2025
Contributor
MexicanAce
left a comment
MexicanAce
left a comment
There was a problem hiding this comment.
LGTM for initial merge
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* feat(swift sdk): swift sdk implementation * feat(swift sdk): addressing comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the Swift SDK and Example app, as well as the core Rust SDK that these are built on.
Additional context
Currently Rust/Swift doesn't yet implement the new passkey signature format (#58) as well as the custom paymaster handler & zyfi integration (#51). Due to this Swift/Rust CI needs to depend on a different version of the contracts submodule.
This PR also depends on forks of alloy-zksync and passkey-rs. In the case of
alloy-zksyncthesdkcrate requires some APIs that are not yet public. In the case ofpasskey-rsthesdkcreate depends on Apple passkey verification support that has not yet been upstreamed. The plan is to upstream both of these soon starting with thealloy-zksyncchanges.