Skip to content

Conversation

@wiggin77
Copy link
Member

@wiggin77 wiggin77 commented Dec 3, 2025

Summary

  • Fix bug where release notes URL was missing a leading slash
  • Replace string concatenation with url.JoinPath() for proper URL construction
  • Handles URLs with or without trailing slashes correctly

Test plan

  • Build the plugin with a release tag and verify the release notes URL is properly formatted
  • Verify the generated URL matches the expected format: https://github.com/mattermost/mattermost-plugin-github/releases/tag/vX.Y.Z

🤖 Generated with Claude Code

Use url.JoinPath() to properly construct the release notes URL instead
of string concatenation, which was missing a leading slash and could
fail with URLs that have trailing slashes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@wiggin77 wiggin77 force-pushed the fix-release-notes-url-slash branch from 5fd0bc5 to 199bb72 Compare December 3, 2025 19:56
@wiggin77 wiggin77 merged commit 9ecaf50 into master Dec 3, 2025
11 checks passed
@wiggin77 wiggin77 deleted the fix-release-notes-url-slash branch December 3, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants