Add tests for PDF generation #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
===========================================
+ Coverage 51.44% 70.96% +19.52%
===========================================
Files 11 11
Lines 243 248 +5
Branches 24 23 -1
===========================================
+ Hits 125 176 +51
+ Misses 118 72 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergei-maertens
force-pushed
the
issue/6-add-weasyprint-tests
branch
3 times, most recently
from
56c9472 to
785b648
Compare
And fixed some indentation issues.
sergei-maertens
force-pushed
the
issue/6-add-weasyprint-tests
branch
from
785b648 to
011ce1a
Compare
sergei-maertens
force-pushed
the
issue/6-add-weasyprint-tests
branch
from
011ce1a to
e7d0fee
Compare
Now that there was good test coverage, there's an opportunity to clean up the code, which should also make it easier to add tests for the remaining uncovered branches.
It's possible a project opts in to a different kind of storage, e.g.
to get files on S3 and in those situations, a storage that's not a
subclass of FileSystemStorage is typically used. We can simulate the
expected behaviour by using the in memory storage shipped by Django.
Note that this storage does not set up a location, which the default
static files storage does (making sure every asset URL is prefixed
with settings.STATIC_URL). As such, the {% static %} template tag
effectively does nothing with this in-memory storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6
Let's get those coverage numbers up :)