✨ [#614] Configure type checking for python code - #655
Merged
Conversation
TimdeBeer1
force-pushed
the
feature/614-add-type-checking
branch
6 times, most recently
from
August 28, 2026 08:45
bdfcd3f to
a026af3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 238 238
Lines 14069 14069
=======================================
Hits 13785 13785
Misses 284 284 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TimdeBeer1
force-pushed
the
feature/614-add-type-checking
branch
from
August 28, 2026 08:49
a026af3 to
fdee401
Compare
TimdeBeer1
force-pushed
the
feature/614-add-type-checking
branch
from
August 28, 2026 09:14
fdee401 to
8d2f7a0
Compare
danielmursa-dev
requested changes
Sep 3, 2026
|
|
||
| from rest_framework.serializers import Serializer | ||
| from rest_framework_nested.serializers import NestedHyperlinkedRelatedField | ||
| from rest_framework_nested.relations import NestedHyperlinkedRelatedField |
Contributor
There was a problem hiding this comment.
How has it worked so far?
Contributor
Author
There was a problem hiding this comment.
NestedHyperlinkedRelatedField is defined in .relations, but in .serializers it gets imported. So at runtime it works, but pyright wants it from relations directly.
danielmursa-dev
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #614
Changes
Added type checking.
Only included utils
Checklist
Commit hygiene
Architectural design record