Feat add sync action #165
Merged
Feat add sync action #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditigopalan
added
priority-high
major
vpchung
approved these changes
Jan 30, 2025
Thank you so much! Let me know if the fixes make sense :) |
vpchung
requested changes
Feb 5, 2025
Co-authored-by: Verena Chung <[email protected]>
Co-authored-by: Verena Chung <[email protected]>
Merging main
Bankso
approved these changes
Mar 5, 2025
vpchung
approved these changes
Mar 10, 2025
Comment on lines
+5
to
+6
| from google.oauth2.service_account import Credentials | ||
| from googleapiclient.discovery import build |
There was a problem hiding this comment.
Not sure if you'd find the effort to switch over worth it, but I really like using gspread library to access and edit Google spreadsheets!
It could make some of the functions below a bit more readable and easier to comprehend right away.
Comment on lines
+35
to
+39
| - name: Create Google Credentials File | ||
| env: | ||
| GOOGLE_CREDENTIALS: ${{ secrets.GOOGLE_CREDENTIALS }} | ||
| run: | | ||
| echo "${GOOGLE_CREDENTIALS}" > google-credentials.json |
There was a problem hiding this comment.
Before merging, let's double-check that this step does not write the credentials to the Action logs. I'm 99.9% sure it won't print to the logs since it's a secret, but better safe than sorry 😅
There was a problem hiding this comment.
OK just verified that it does not - we good!
Pulling changes from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
This GitHub Action automates the process of syncing a specified Google Sheet to a GitHub repository as a CSV file, facilitating RFC integration.
Key Features:
cron) or can be triggered manually.spreadsheet_id: The Google Sheet ID to monitor.stop_dayandstop_time: Defines when the action should stop execution.RFC-{GoogleSheetName}.RFC_DATA/{GoogleSheetName}.csv.RFC_TOKEN(Personal Access Token) andGOOGLE_CREDENTIALSstored securely as GitHub Secrets.Workflow:
RFC_DATAfolder on the corresponding branch.Script is tested and RFC Integration works, but test on actual action pending merge
Note: I used Google credentials from HTAN. Does MC2 have a google service account? If so those credentials should be updated.
The end result will look something like #164