-
Couldn't load subscription status.
- Fork 1
Curation + CRDC mapping updates #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Not Applicable as a valid value
Update format and content of auto-generate Dataset View JSON schema
Template for Synapse project schema that relates DUO codes to access restrictions
Remove maxItems from JSON schema
Adjust File Longitudinal Event Type description to better describe intent of attribute
Added Data Catalog attributes, descriptions, and model definition. Descriptions contain notes on equivalent annotations in other MC2 data model components
Add Grant End Date as attribute and include in Grant View model
Add mapping of assay annotations to portal icon tags for the CCKP
This reverts commit 691193c.
To help prepare resource content tags for the CCKP, this file relates valid values for assay with high level categorical labels. This is intended to be used as input during portal sync operations.
Add DUOplus attributes and identify existing Study attributes that map to some DUOplus elements
Add valid value mappings for DUOplus analogs Study Source Geography, Study Data Permission, Study Data Tier
Add additional licenses described in DUOplus6
Add valid values to all_valid_values.csv and new Study attributes
Collate model CSV and convert to JSON-LD with schematic 24.12.1
Add additional dataCatalog attributes defined in sage-datasets schema: https://raw.githubusercontent.com/Sage-Bionetworks/core-models/cbad4328d388929c93e4fd8bc7c8a4eee97ee934/data-models/sage-datasets/datasets-json-schema.json
Add valid value mappings for dataCatalog model
Allow multiple assays to be designated for a file. For example, allow selection of "Hematoxylin and Eosin Staining Method" and "Imaging" or "Immunohistochemistry Staining Method" and "Fluorescence Microscopy"
schematic 24.12.1
Add item typing to template JSON schema
Indicate duoCodes annotation is required to satisfy if statement and trigger ARs
Add duoCodes requirement to template if statement
|
@aditigopalan could you look over this PR when you have a chance? |
aditigopalan
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took me a while to go through everything, lgtm 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog