Updated ros_lib library #191
Conversation
veronikaslobo
requested review from
JPGC04,
andrew-kan,
asiancooki and
thirteenlizards
as code owners
|
Note: to be tested before merging |
thirteenlizards
requested review from
Alb33rt
and removed request for
Alb33rt and
andrew-kan
|
@Alb33rt @Rain1618 @nadimasmar please review + confirm the ros custom messages included here; ideally we do not modify this again so if there's anything you anticipate for the future let us know. |
Signed-off-by: Yau Chau <[email protected]>
thirteenlizards
left a comment
thirteenlizards
left a comment
There was a problem hiding this comment.
Commit corresponding to mcgill-robotics/AUV-2025#752 "Update custom messages to sync with AUV-2026 message definitions"
Merge not currently needed, using this branch on its own for now with corresponding AUV-2025 branch.
JPGC04
left a comment
JPGC04
left a comment
There was a problem hiding this comment.
You need to decide whether to merge this pr.
This pr is the latest of what can work with AUV-2025 in ros1
However, it has not been tested extensively, just lightly.
If you want ros1 stuff to work in any way whatsoever i would recommens merginf this. But if you are 100% certain u are abandoning at all costs then i dont know id you should merge.
Take that decision but decide what to do with this pr so its not there forever.
No description provided.