Update custom messages to sync with AUV-2026 message definitions #752
Conversation
nadimasmar
changed the title
JPGC04
dismissed stale reviews from veronikaslobo and WilliamZhang2205
via
5539a47
|
This was tested with auv-sim-unity on branch custom_messages_change. It works but I noticed the red (auv belief) was lagging and I am guessing it was the computer not able to process sensor messages as fast as needed. |
Alb33rt
left a comment
Alb33rt
left a comment
There was a problem hiding this comment.
Changes make sense to match more in-line with ROS definitions and conventions. The embedded enum approach might change, but only to a less complex case. Code logic changes make sense.
nadimasmar
left a comment
nadimasmar
left a comment
There was a problem hiding this comment.
There is the issue of AUV belief in the sim drifting rapidly on this branch. Whether the cause of the problem is change to AUV-2025 or the sim-unity code, we should resolve it before merging
There was a problem hiding this comment.
Commit corresponding to mcgill-robotics/auv-embedded-2026#191 "Updated ros_lib library"
Merge not currently needed, using this branch on its own for now with corresponding embedded branch.
No description provided.