Fix FileDescription in exe file properties#645
Conversation
|
| { | ||
| "name": "mediago", | ||
| "version": "3.5.0", | ||
| "description": "A powerful and easy-to-use online video downloader", |
There was a problem hiding this comment.
${process.env.APP_NAME} installer,
I've already updated the installer description here.
There was a problem hiding this comment.
I beleiev that also you can apply the changes because there are no negative point to change file description in the position that I made.
I added also other changes to enable Italian language.
There was a problem hiding this comment.
Sounds good. Any other commits to review?
There was a problem hiding this comment.
You can add in install.nsh
BrandingText "${PRODUCT_NAME} ${VERSION}"
and remove
Caption "Setup - ${PRODUCT_NAME} ${VERSION}"
In this way on bottom left you wiill see product name and version.
There was a problem hiding this comment.
About "description" in your doc is reported that it change Filedescription (that used only in file properties).
Infact currently the string
"A powerful and easy-to-use online video downloader"
is the File description that I can see with right click on installer exe -> File properties,
it should be "mediago installer".
Apply the changes make a build to check all optimizations.
There was a problem hiding this comment.
@bovirus Thanks for the new PR! 👍
I've updated a few files on master. Could you merge the latest master into your branch?
@caorushizi
Fix FileDescription in installer exe file properties