Skip to content

Fix FileDescription in exe file properties #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bovirus wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix FileDescription in exe file properties #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b47655
Fix FileDescription in exe file properties
bovirus Apr 22, 2026
bccdaa8
Add settings for Italian language
bovirus Apr 22, 2026
1820ae2
Add settings for Italian
bovirus Apr 22, 2026
dc5329e
Add Italian language option to AppLanguage enum
bovirus Apr 22, 2026
6c26903
Add Italian language option to settings
bovirus Apr 22, 2026
ab4ef0e
Change caption to branding text in installer script
bovirus Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/electron/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "mediago",
"version": "3.5.0",
"description": "A powerful and easy-to-use online video downloader",

@caorushizi caorushizi Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${process.env.APP_NAME} installer,

I've already updated the installer description here.

@bovirus bovirus Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caorushizi

I beleiev that also you can apply the changes because there are no negative point to change file description in the position that I made.

I added also other changes to enable Italian language.

@caorushizi caorushizi Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Any other commits to review?

@bovirus bovirus Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add in install.nsh

BrandingText "${PRODUCT_NAME} ${VERSION}"

and remove

Caption "Setup - ${PRODUCT_NAME} ${VERSION}"

In this way on bottom left you wiill see product name and version.

@bovirus bovirus Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caorushizi

About "description" in your doc is reported that it change Filedescription (that used only in file properties).

Infact currently the string
"A powerful and easy-to-use online video downloader"
is the File description that I can see with right click on installer exe -> File properties,

image

it should be "mediago installer".

Apply the changes make a build to check all optimizations.

@y2hlbg y2hlbg Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bovirus Thanks for the new PR! 👍

I've updated a few files on master. Could you merge the latest master into your branch?

"description": "mediago installer",
"main": "main/index.js",
"type": "module",
"author": "caorushizi",
Expand Down
2 changes: 1 addition & 1 deletion apps/electron/installer/installer.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@
; Trade-off: title bar reads "Setup - mediago-community 3.5.0" in every
; locale instead of the translated "Installazione di ..." — acceptable.
; ---------------------------------------------------------------------
Caption "Setup - ${PRODUCT_NAME} ${VERSION}"
BrandingText "${PRODUCT_NAME} ${VERSION}"
!macroend
1 change: 1 addition & 0 deletions apps/ui/src/pages/setting-page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ const SettingPage: React.FC = () => {
{ label: t("followSystem"), value: AppLanguage.System },
{ label: t("chinese"), value: AppLanguage.ZH },
{ label: t("english"), value: AppLanguage.EN },
{ label: t("italian"), value: AppLanguage.IT },
]}
placeholder={t("pleaseSelectLanguage")}
allowClear={false}
Expand Down
6 changes: 3 additions & 3 deletions packages/shared/common/src/i18n/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const BASE_I18N_OPTIONS = {
} as const;

/**
* Resolve a stored AppStore.language value to a real i18n key ("zh" | "en").
* Resolve a stored AppStore.language value to a real i18n key ("zh" | "en" | "it").
*
* The persisted language may be `"system"` (meta value meaning "follow OS locale").
* Each process resolves it at apply-time by passing its own locale source:
Expand All @@ -19,8 +19,8 @@ export const BASE_I18N_OPTIONS = {
export function resolveAppLanguage(
language: string | undefined,
systemLocale: string | undefined,
): "zh" | "en" {
if (language === "zh" || language === "en") {
): "zh" | "en" | "it" {
if (language === "zh" || language === "en") || language === "it") {
return language;
}
return (systemLocale ?? "").toLowerCase().startsWith("zh") ? "zh" : "en";
Expand Down
6 changes: 4 additions & 2 deletions packages/shared/common/src/i18n/resources/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import { en } from "./en";
import { zh } from "./zh";
import { it } from "./it";

export const i18nResources = {
en,
zh,
it,
} as const;

export const SUPPORTED_LANGUAGES = ["en", "zh"] as const;
export const SUPPORTED_LANGUAGES = ["en", "zh", "it"] as const;
export const DEFAULT_BACKEND_NAMESPACE = "backend" as const;
export const DEFAULT_FRONTEND_APP = "main" as const;

export { en, zh };
export { en, zh, it };
1 change: 1 addition & 0 deletions packages/shared/common/src/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export enum AppLanguage {
System = "system",
ZH = "zh",
EN = "en",
IT = "it",
}

export interface DownloadContext {
Expand Down