Add federated multisearch to MeilisearchClient

[apt-TebbeM]

Pull Request

Related issue

Fixes #560

What does this PR do?

• increases meilisearch version to 1.10.0 in docker-compose.yaml
• adds new method on MeilisearchClient for federated search
• extracts shared properties of "FederatedSearchQuery" and "SearchQuery" into a SearchQueryBase
• add custom JsonConverter to handle federated search in request (empty object needs to be included, cause that causes federated search to work)
• added tests

PR checklist

Please check if your PR fulfills the following requirements:

• [ x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• [ x ] Have you read the contributing guidelines?
• [ x ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[curquiza]

Hello @apt-TebbeM

thank you for your PR! Let me know when the PR is ready 😊

[apt-TebbeM]

I think it could be reviewed. I actually thought about chaning the API for the federated search part to something like this:

public async Task<ISearchable<T>> FederatedMultiSearchAsync<T>(List<FederatedSearchQuery> queries,
            MultiSearchFederationOptions federationOptions = default(MultiSearchFederationOptions),
            CancellationToken cancellationToken = default)

to make it less likely to have an empty list of queries.

[apt-TebbeM]

Hello @apt-TebbeM

thank you for your PR! Let me know when the PR is ready 😊

you can go ahead

[apt-TebbeM]

@curquiza when will this pr be reviewed? :)

[curquiza]

Hello @apt-TebbeM I'm sorry but I have a loooot on my plate right now. I will maybe be able to review your PR next week. I'll do my best. But busy work period at the moment

But be sure I don't forget you!

[curquiza]

@apt-TebbeM if you are still here, can you answer @ahmednfwela point above 👆 so that we can improve or merge the PR?

[apt-TebbeM]

@curquiza @ahmednfwela I've updated the PR as suggested

[apt-TebbeM]

Is there still a desire for this to be merged? @ahmednfwela

[ahmednfwela]

I don't see what problem does this converter solve

[apt-TebbeM]

The API requiers a empty "federation" object when calling the /multisearch endpoint this is to respond in the expected format:

{
  "hits": [ ...],
  "processingTimeMs": 4,
  "limit": 20,
  "offset": 0,
  "estimatedTotalHits": 11
}

When the empty object parameter is not included it responds in a totaly different way:

{
  "results": [
    {
      "indexUid": "searchIndex1",
      "hits": [...],
      "query": "w",
      "processingTimeMs": 4,
      "limit": 20,
      "offset": 0,
      "estimatedTotalHits": 11
    },
    {
      "indexUid": "searchIndex2",
      "hits": [...],
      "query": "w",
      "processingTimeMs": 0,
      "limit": 20,
      "offset": 0,
      "estimatedTotalHits": 0
    },
    {
      "indexUid": "searchIndex3",
      "hits": [...],
      "query": "w",
      "processingTimeMs": 0,
      "limit": 20,
      "offset": 0,
      "estimatedTotalHits": 0
    }
  ]
}

[apt-TebbeM]

What are the next steps here? @curquiza @ahmednfwela