Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add federated multisearch to MeilisearchClient #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add federated multisearch to MeilisearchClient #571
Changes from 6 commits
6ce6924
b50817b
1597f9c
b9566c5
1ff060e
bc3b89e
093e63f
625bfcd
22da0ba
e973642
8ece4e4
1feea8e
fcf9073
38a88ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 13 in src/Meilisearch/Converters/AlwaysIncludeEmptyObjectConverter.cs
Check warning on line 13 in src/Meilisearch/Converters/AlwaysIncludeEmptyObjectConverter.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see what problem does this converter solve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API requiers a empty "federation" object when calling the /multisearch endpoint this is to respond in the expected format:
When the empty object parameter is not included it responds in a totaly different way: