Skip to content

Update to elixir 1.19 - #1038

Merged
Noarkhh merged 8 commits into
masterfrom
elixir-update
Dec 18, 2025
Merged

Update to elixir 1.19#1038
Noarkhh merged 8 commits into
masterfrom
elixir-update

Conversation

@Noarkhh

@Noarkhh Noarkhh commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

I'll suppress warnings from problematic functions, the bug is described here: elixir-lang/elixir#14576

@Noarkhh Noarkhh added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label Dec 10, 2025
@Noarkhh
Noarkhh marked this pull request as ready for review December 10, 2025 15:39
@Noarkhh
Noarkhh requested a review from mat-hek as a code owner December 10, 2025 15:39
@Noarkhh Noarkhh added this to Smackore Dec 10, 2025
@Noarkhh Noarkhh moved this to In Review in Smackore Dec 10, 2025
@Noarkhh Noarkhh self-assigned this Dec 10, 2025
@Noarkhh Noarkhh moved this from In Review to In Progress in Smackore Dec 11, 2025
Initializes pads info basing on element's or bin's pads specifications.
"""
@spec init_pads(Element.State.t()) :: Element.State.t()
# @spec init_pads(Element.State1.t()) :: Element.State1.t()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

Comment thread lib/membrane/core/element/state.ex
Comment thread lib/membrane/core/element.ex Outdated
Comment on lines +105 to +106
# Suppress false positive dialyzer warnings
# https://github.com/elixir-lang/elixir/issues/14576

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention which type causes the error whenever suppressing warnings

@Noarkhh
Noarkhh requested a review from mat-hek December 18, 2025 14:35
Comment thread lib/membrane/core/element.ex Outdated
Comment on lines +105 to +106
# Suppress false positive dialyzer warnings resulting from
# broken handling of opaque types

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to write which opaque type causes the warning :P

@Noarkhh
Noarkhh merged commit b90fdf2 into master Dec 18, 2025
5 of 6 checks passed
@Noarkhh
Noarkhh deleted the elixir-update branch December 18, 2025 15:58
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Smackore Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants