[WC-3250] DG: single select col header accessibility#2103
Open
[WC-3250] DG: single select col header accessibility#2103
Conversation
r0b1n
reviewed
Feb 19, 2026
| <translation lang="nl_NL">Selecteer alle rijen</translation> | ||
| </translations> | ||
| </property> | ||
| <property key="selectSingleRowLabel" type="textTemplate" required="false"> |
Collaborator
There was a problem hiding this comment.
I think this name can do better. It says select, but this is a caption, not label of a button that performs actual select action. It says row, but this is to describe a column, not a row.
Contributor
Author
There was a problem hiding this comment.
Looking at the propertygroup and neighboring property names, I would call it singleSelectionColumnLabel. Because we're naming an aria label in this panel.
r0b1n
reviewed
Feb 19, 2026
| </property> | ||
| <property key="selectSingleRowLabel" type="textTemplate" required="false"> | ||
| <caption>Select single row label</caption> | ||
| <description>If single selection is enabled, assistive technology will read this for the selection column header.</description> |
Collaborator
There was a problem hiding this comment.
Do we want to hide this property when single selection is not enabled?
r0b1n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description