-
Notifications
You must be signed in to change notification settings - Fork 69
[WC-3250] DG: single select col header accessibility #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yordan-st
wants to merge
2
commits into
main
Choose a base branch
from
feat/WC-3260_DG-colheader-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -446,6 +446,14 @@ | |
| <translation lang="nl_NL">Selecteer alle rijen</translation> | ||
| </translations> | ||
| </property> | ||
| <property key="selectSingleRowLabel" type="textTemplate" required="false"> | ||
| <caption>Select single row label</caption> | ||
| <description>If single selection is enabled, assistive technology will read this for the selection column header.</description> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to hide this property when single selection is not enabled? |
||
| <translations> | ||
| <translation lang="en_US">Select single row</translation> | ||
| <translation lang="nl_NL">Selecteer enkele rij</translation> | ||
| </translations> | ||
| </property> | ||
| <property key="selectingAllLabel" type="textTemplate" required="false"> | ||
| <caption>Selecting all label</caption> | ||
| <description>ARIA label for the progress dialog when selecting all items</description> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...ages/pluggableWidgets/datagrid-web/src/components/__tests__/CheckboxColumnHeader.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { Fragment } from "react"; | ||
|
|
||
| describe("CheckboxColumnHeader", () => { | ||
| it("renders sr-only text with correct class and content for single selection", () => { | ||
| render( | ||
| <div className="th widget-datagrid-col-select" role="columnheader"> | ||
| <span className="sr-only">Select single row</span> | ||
| </div> | ||
| ); | ||
|
|
||
| const srOnlyText = screen.getByText("Select single row"); | ||
| expect(srOnlyText).toBeInTheDocument(); | ||
| expect(srOnlyText).toHaveClass("sr-only"); | ||
| expect(srOnlyText.parentElement).toHaveClass("widget-datagrid-col-select"); | ||
| expect(srOnlyText.parentElement).toHaveAttribute("role", "columnheader"); | ||
| }); | ||
|
|
||
| it("renders sr-only text with custom label", () => { | ||
| render( | ||
| <div className="th widget-datagrid-col-select" role="columnheader"> | ||
| <span className="sr-only">Choose one row</span> | ||
| </div> | ||
| ); | ||
|
|
||
| const srOnlyText = screen.getByText("Choose one row"); | ||
| expect(srOnlyText).toBeInTheDocument(); | ||
| expect(srOnlyText).toHaveClass("sr-only"); | ||
| }); | ||
|
|
||
| it("renders multiple column headers with sr-only text for single selection", () => { | ||
| render( | ||
| <div> | ||
| <div className="th widget-datagrid-col-select" role="columnheader"> | ||
| <span className="sr-only">Select single row</span> | ||
| </div> | ||
| <div className="th" role="columnheader"> | ||
| <span>Column 1</span> | ||
| </div> | ||
| </div> | ||
| ); | ||
|
|
||
| const srOnlyText = screen.getByText("Select single row"); | ||
| const columnHeader = screen.getByText("Column 1"); | ||
|
|
||
| expect(srOnlyText).toBeInTheDocument(); | ||
| expect(columnHeader).toBeInTheDocument(); | ||
| expect(srOnlyText).toHaveClass("sr-only"); | ||
| expect(columnHeader).not.toHaveClass("sr-only"); | ||
| }); | ||
|
|
||
| it("sr-only text has sr-only class applied", () => { | ||
| render( | ||
| <div className="th widget-datagrid-col-select" role="columnheader"> | ||
| <span className="sr-only">Select single row</span> | ||
| </div> | ||
| ); | ||
|
|
||
| const srOnlyText = screen.getByText("Select single row"); | ||
|
|
||
| // sr-only class typically hides content visually but keeps it available to screen readers | ||
| // Check that it has sr-only class applied | ||
| expect(srOnlyText).toHaveClass("sr-only"); | ||
| }); | ||
|
|
||
| it("renders empty fragment when checkbox is disabled", () => { | ||
| const { container } = render(<Fragment />); | ||
|
|
||
| expect(container.firstChild).toBeNull(); | ||
| expect(screen.queryByText("Select single row")).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("does not render sr-only text for multi-selection", () => { | ||
| render( | ||
| <div className="th widget-datagrid-col-select" role="columnheader"> | ||
| <input type="checkbox" aria-label="Select all rows" /> | ||
| </div> | ||
| ); | ||
|
|
||
| const checkbox = screen.getByRole("checkbox"); | ||
| expect(checkbox).toBeInTheDocument(); | ||
| expect(screen.queryByText("Select single row")).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("columnheader contains only sr-only text for single selection", () => { | ||
| const { container } = render( | ||
| <div className="th widget-datagrid-col-select" role="columnheader"> | ||
| <span className="sr-only">Select single row</span> | ||
| </div> | ||
| ); | ||
|
|
||
| const columnHeader = container.querySelector('[role="columnheader"]'); | ||
| const srOnlySpans = columnHeader?.querySelectorAll(".sr-only"); | ||
|
|
||
| expect(columnHeader).toBeInTheDocument(); | ||
| expect(srOnlySpans).toHaveLength(1); | ||
| expect(srOnlySpans?.[0]).toHaveTextContent("Select single row"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this name can do better. It says
select, but this is a caption, not label of a button that performs actualselectaction. It saysrow, but this is to describe a column, not a row.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the propertygroup and neighboring property names, I would call it
singleSelectionColumnLabel. Because we're naming an aria label in this panel.