-
Notifications
You must be signed in to change notification settings - Fork 642
Fix: Correct UI layout on meshery.io/programs page #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: abhi2002dhi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dhimanAbhi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses several UI layout issues on the Programs page, aiming to improve responsiveness and alignment. The changes include fixing the card layout to wrap into multiple rows, preventing text overflow on hover, and properly aligning list items in the Community section. The changes touch both the HTML template and CSS files to achieve the desired layout and styling adjustments.
Highlights
- Card Layout Fix: The program cards now wrap into multiple rows instead of appearing in a single row, improving responsiveness on different screen sizes. This was achieved by modifying the
_includes/program-lists.html
file. - Hover Text Overflow Prevention: Text overflow when hovering over program cards has been prevented, enhancing the user experience. This was achieved by modifying the
_includes/program-lists.html
file. - Section Alignment Fix: The list items in the Community section are now properly aligned, resolving a visual inconsistency. This was achieved by modifying the
css/program.css
file. - Container Width Adjustment: The maximum width of the text container has been increased to 1140px to better accommodate content. This was achieved by modifying the
_sass/layout.scss
file.
Changelog
- _includes/program-lists.html
- Added
display: flex
,align-items: center
,justify-content: center
, andheight: 100%
to.card .info
to center the content within the card. - Added
line-height: normal
to.card .info h1
to prevent text from overflowing.
- Added
- _sass/layout.scss
- Increased
max-width
of.text-container
from750px
to1140px
.
- Increased
- css/program.css
- Added
margin: 0 0 0 20px
toh3
to adjust spacing. - Modified
.programlist-subscribe .discuss-community
to usegap: 2rem
instead ofwidth: 80vw
andgap: 1rem
. - Increased
width
of.programlist-subscribe .form-container
from40rem
to50rem
. - Added
margin: 20px 0 10px 0
toh3
within the media query for smaller screens.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A layout's a tricky thing,
Alignment's the song it sings.
With flex and with grid,
A perfect fit is bid,
Where beauty and function bring.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR addresses UI inconsistencies on the Programs page, improving responsiveness and alignment. The changes seem reasonable and address the issues described. However, there are a few areas where improvements can be made to enhance the code's clarity and maintainability.
Summary of Findings
- CSS Specificity: The use of
!important
in the CSS can lead to specificity issues and make it harder to override styles in the future. It's generally better to avoid!important
and instead rely on CSS specificity to ensure styles are applied correctly. I did not comment on this due to the review settings. - Magic Numbers: The use of magic numbers (e.g.,
20px
,50rem
) without clear context or explanation can make the code harder to understand and maintain. Consider using variables or constants to represent these values with meaningful names. I did not comment on this due to the review settings.
Merge Readiness
The PR addresses the described UI issues and improves the Programs page's layout. However, addressing the suggested improvements, particularly regarding CSS specificity and magic numbers, would further enhance the code's quality and maintainability. I am unable to approve this pull request, and other reviewers should review and approve this code before merging. Given the medium
severity issues identified, I recommend addressing them before merging.
@@ -58,6 +58,7 @@ h3 { | |||
font-size: 1.7em; | |||
color: var(--color-secondary-medium); | |||
position:relative; | |||
margin: 0 0 0 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display: flex; | ||
width: 80vw; | ||
gap: 1rem; | ||
gap: 2rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -231,7 +231,7 @@ a:active { | |||
} | |||
|
|||
.programlist-subscribe .form-container{ | |||
width: 40rem; | |||
width: 50rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -491,6 +491,10 @@ img { | |||
padding: 0rem 0.5rem !important; | |||
} | |||
|
|||
h3{ | |||
margin: 20px 0 10px 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
This PR resolves multiple UI inconsistencies on the Programs page, improving responsiveness and alignment.
This PR fixes #2105
Screenshots
Programs._.Meshery.-.Brave.2025-04-02.16-19-32.mp4
Notes for Reviewers
Signed commits