Skip to content

Fix: Correct UI layout on meshery.io/programs page #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhimanAbhi wants to merge 1 commit into from
Closed

Fix: Correct UI layout on meshery.io/programs page #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions _includes/program-lists.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
}
.card .info {
position: relative;
display: flex;
align-items: center;
justify-content: center;
height: 100%;
z-index: 3;
color: white;
opacity: 0;
Expand All @@ -69,6 +73,7 @@
}
.card .info h1 {
margin: 0px;
line-height: normal;
}
.card .info p {
letter-spacing: 1px;
Expand Down
2 changes: 1 addition & 1 deletion _sass/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}

.text-container {
max-width: 750px;
max-width: 1140px;
}

.container {
Expand Down
10 changes: 7 additions & 3 deletions css/program.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ h3 {
font-size: 1.7em;
color: var(--color-secondary-medium);
position:relative;
margin: 0 0 0 20px;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider defining this margin using a CSS variable to ensure consistency and easier modification across the project. This also helps in understanding the context of the value.

  margin: 0 0 0 var(--space-s); /* Use a defined variable for spacing */

}
h4 {
font-weight: 400;
Expand Down Expand Up @@ -206,8 +207,7 @@ a:active {

.programlist-subscribe .discuss-community{
display: flex;
width: 80vw;
gap: 1rem;
gap: 2rem;
Comment on lines 209 to +210
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using CSS variables for spacing to maintain consistency across the project. This makes it easier to adjust spacing values globally.

  gap: var(--space-m); /* Use a defined variable for spacing */

margin: 0 auto;
}

Expand All @@ -231,7 +231,7 @@ a:active {
}

.programlist-subscribe .form-container{
width: 40rem;
width: 50rem;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using CSS variables for width to maintain consistency across the project. This makes it easier to adjust width values globally.

  width: var(--form-container-width); /* Use a defined variable for width */

/* padding: 2rem 0; */
/* padding-bottom: 6rem; */
margin: 0 auto;
Expand Down Expand Up @@ -491,6 +491,10 @@ img {
padding: 0rem 0.5rem !important;
}

h3{
margin: 20px 0 10px 0;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider defining these margins using CSS variables to ensure consistency and easier modification across the project. This also helps in understanding the context of the value.

    margin: var(--space-m) 0 var(--space-s) 0; /* Use defined variables for spacing */

}

.subscribe {
width: 100%;
height: auto;
Expand Down
Loading