✨ Allow forced detachment of a host from Ironic

[CrystalChun]

What this PR does / why we need it:
Introduces the force argument for detaching. If set to true, it would bypass whichever status the host is currently in, abort the action in Ironic, and force the host's detachment.

Note: there is a soft dependency on the new feature in Ironic that allows the abort action on deploying nodes. Without it, deprovisioning will be triggered first, which won't preserve the exact host's state.

Finally, I have prepared e2e tests for this change, but they ended up being timing-dependent. To fix this dependency, I need direct access to Ironic Node record, which is going to greatly increase the already large size of this change. The tests will be proposed separately.

Fixes #2923

Checklist:

• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• E2E tests have been added, if necessary.
• Integration tests have been added, if necessary.

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rozzii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[metal3-io-bot]

Hi @CrystalChun. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dtantsur]

/ok-to-test

[dtantsur]

@CrystalChun while I'm testing something locally, could you squash your commits and remove references to RH Jira from the messages?

[CrystalChun]

@CrystalChun while I'm testing something locally, could you squash your commits and remove references to RH Jira from the messages?

Yes, squashed my commits and removed the RH Jira mentions from the commit message and the description of this PR!

[dtantsur]

@CrystalChun I've provided a draft implementation, needs testing now (also together with soon-to-be-merged Ironic change https://review.opendev.org/c/openstack/ironic/+/973279)

[dtantsur]

/hold

Despite 2 seconds sleep, one of the tests still did not reach "deploying" before forced detachment was applied.

[dtantsur]

/hold cancel

I had to drop the e2e tests for now to avoid blocking the entire feature. There are signs that they would pass, but they're timing-dependent, which is pretty bad. I'll propose them separately.

[Rozzii]

I will take a look soon, for some reason this PR have not received the 2reviewer automatically.
/cc @Rozzii

[Rozzii]

In my review queue now, I would like to merge this before 0.13 release @Sunnatillo @smoshiur1237 please keep an eye on this PR.

[Copilot]

Pull request overview

Adds support for forced BareMetalHost detachment so operators can request immediate detachment even when the host is mid-operation, with Ironic-side logic attempting to abort in-progress workflows when possible.

Changes:

• Extend the Provisioner interface and controller detachment flow to accept a force boolean.
• Implement forced-detach behavior in the Ironic provisioner by reusing deletion logic and issuing abort/fallback transitions depending on Ironic microversion support.
• Add unit tests for Ironic forced-detach behavior and introduce an API annotation argument (force) to trigger forced detachment.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/provisioner/provisioner.go	Updates the provisioner interface to accept a force flag for detachment.
pkg/provisioner/ironic/ironic.go	Refactors deletion into realDelete(..., force) and wires Detach(..., force) to use it, including abort/deprovision logic by state.
pkg/provisioner/ironic/delete_test.go	Adds unit test coverage for forced detachment state handling and updates existing detach calls for the new signature.
pkg/provisioner/ironic/clients/features.go	Adds detection for deployment-abort support and selects microversion 1.110 when available.
pkg/provisioner/fixture/fixture.go	Updates fixture provisioner to implement the new Detach(ctx, force) signature.
pkg/provisioner/demo/demo.go	Updates demo provisioner to implement the new Detach(ctx, force) signature.
internal/controller/metal3.io/host_state_machine_test.go	Updates mock provisioner to match the new Detach(ctx, force) signature.
internal/controller/metal3.io/host_state_machine.go	Enables forced detach via detached annotation JSON args and adjusts delete initiation behavior for detached hosts.
internal/controller/metal3.io/baremetalhost_controller.go	Plumbs the force flag through reconciler detachment handling.
apis/metal3.io/v1alpha1/baremetalhost_types.go	Adds force to DetachedAnnotationArguments for annotation-driven forced detachment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new forced-detach path (hasForceDetachAnnotation + passing force=true into detachHost) is not covered by the existing host state machine unit tests. Add a unit test that sets the detached annotation payload to JSON with {"force":true} while the host is in a non-detachable provisioning state (e.g. StateProvisioning) and asserts the reconciler calls Provisioner.Detach(..., true) and transitions OperationalStatus to Detached appropriately.