Remove MariaDB support - #1710
Conversation
metal3-io-bot
added
the
size/S
|
/test all |
|
/test shellcheck |
|
/test metal3-centos-e2e-integration-test-release-1-13 |
|
/test metal3-centos-e2e-integration-test-release-1-13 |
metal3-io-bot
added
lgtm
81d2c08 to
4caba74
Compare
|
New changes are detected. LGTM label has been removed. |
metal3-io-bot
added
size/M
4caba74 to
ffebc4d
Compare
|
/test metal3-centos-e2e-integration-test-release-1-13 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/copilot-review |
|
Copilot code review has been requested by @tuminoid. Please allow a few moments for the review to be added. |
There was a problem hiding this comment.
Pull request overview
Removes runtime MariaDB support from Ironic deployment paths.
Changes:
- Removes MariaDB flags, configuration, and IRSO resources.
- Removes the MariaDB test variable and documentation.
- Adds unrelated basic-auth argument handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
03_launch_mgmt_cluster.sh |
Removes MariaDB deployment logic and adds basic-auth handling. |
tests/roles/run_tests/vars/main.yml |
Replaces MariaDB test arguments with basic-auth arguments. |
vars.md |
Removes the MariaDB option and adds inspector-password documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if [[ "${IRONIC_BASIC_AUTH:-true}" = "false" ]]; then | ||
| BMO_IRONIC_ARGS+=("-n") |
There was a problem hiding this comment.
I agree, please don't reintroduce the option to not have basic auth.
There was a problem hiding this comment.
I agree too, I missed this, lets not add un-related setting here
/hold
There was a problem hiding this comment.
Thank you both, I dropped the IRONIC_BASIC_PATH handling and the unrelated basic-auth arg/doc changes.
metal3-io-bot
added
the
do-not-merge/hold
This removes the IRONIC_USE_MARIADB option that let the dev-env deploy Ironic with a MariaDB backend. It drops the -m flag passed to the BMO deploy script, the IRONIC_USE_MARIADB entry written into the Ironic configmap, and the IronicDatabase resource created on the IRSO path, together with the matching test variable and the documentation rows in vars.md. **NOTE**:The related MariaDB image-build variables and TLS certificate setup are removed separately in metal3-io#1698. Signed-off-by: Migi Jylhä <migi.jylha@est.tech>
ffebc4d to
2ba50d7
Compare
metal3-io-bot
added
size/S
|
/test metal3-centos-e2e-integration-test-release-1-13 |
This removes the IRONIC_USE_MARIADB option that let the dev-env deploy Ironic with a MariaDB backend.
It drops the -m flag passed to the BMO deploy script, the IRONIC_USE_MARIADB entry written into the Ironic configmap, and the IronicDatabase resource created on the IRSO path, together with the matching test variable and the documentation row in vars.md.
NOTE:The related MariaDB image-build variables and TLS certificate setup are removed separately in #1698. In addition, a follow-up BMO PR removes the -m flag and the kustomize component, it depends on this merging first.